On Sun, Mar 10, 2019 at 4:21 PM Nadav Har'El <n...@scylladb.com> wrote:
> On Sat, Mar 9, 2019 at 3:02 AM geraldo netto <geraldone...@gmail.com> > wrote: > >> >> +@@ -41,5 +41,5 @@ >> + <user username="both" password="<must-be-changed>" >> roles="tomcat,role1"/> >> + <user username="role1" password="<must-be-changed>" roles="role1"/> >> > > I understood from your patch's title that the purpose of this patch is to > add the "admin-gui" > role to user tomcat, but didn't quite understand why you are doing this, > and if this is a new > tomcat 9 thing. But anyway, how is this related to the above change of > users "both" and "role1", > which if I understand correctly the existing patches (which removed those > usernames), we don't need at all? > Oops, I just finally realized that this is not a regular patch, it's a patch of a *patch*, so this "+" isn't a line you added, but rather a context line, i.e., an existing line in the patch (in this case, a line you added to this patch in your previous patch). So I need to ask this question there. > --> >> - <role rolename="tomcat"/> >> -- <user username="tomcat" password="tomcat" roles="manager-gui"/> >> -+ <user username="tomcat" password="tomcat" >> roles="manager-gui,admin-gui"/> >> +-<user username="tomcat" password="tomcat" roles="manager-gui"/> >> ++<user username="tomcat" password="tomcat" >> roles="manager-gui,admin-gui"/> >> </tomcat-users> >> -- >> 1.8.1.2 >> -- >> 2.17.1 >> >> -- >> You received this message because you are subscribed to the Google Groups >> "OSv Development" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to osv-dev+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to osv-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.