[osv-dev] [PATCH] osv: properly assign gsi number inside handler

['YuChen Qian' via OSv Development]

From: yuchenq <yuch...@amazon.de>

Initialize the gsi number inside handler to an unreachable number. The
gsi number was not properly initialized and default to 0 previously, and
caused interrupt misfiring for level triggered interrupts on pin 0 when
it checks for the gsi number for interrupt sharing. This commit fixed
the misfiring on pin 0.

Fixes: 5fc9daf82ffc ("interrupt: Support interrupt sharing")
Signed-off-by: YuChen Qian <yuch...@amazon.de>
Reviewed-by: Amadeusz Juskowiak <aj...@amazon.de>
Reviewed-by: Marius Hillenbrand <mhill...@amazon.de>
Cc-Team: kaos-brimstone <kaos-brimst...@amazon.com>

CR: https://code.amazon.com/reviews/CR-14472907
---
 arch/x64/exceptions.hh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x64/exceptions.hh b/arch/x64/exceptions.hh
index 0fbeaba5..570322a6 100644
--- a/arch/x64/exceptions.hh
+++ b/arch/x64/exceptions.hh
@@ -117,6 +117,7 @@ private:
                     break;
                 }
             }
+            gsi = -1u;
         }
 
         handler(handler *h,
@@ -131,6 +132,7 @@ private:
             ids.push_back(id++);
             pre_eois.push_back(_pre_eoi);
             post_eois.push_back(_post_eoi);
+            gsi = -1u;
         }
 
         unsigned size()
-- 
2.17.1




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879



-- 
You received this message because you are subscribed to the Google Groups "OSv 
Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to osv-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/osv-dev/20191204084413.5400-1-yuchenq%40amazon.de.