Waldek Kozaczuk <[email protected]> writes: > This also does not work on Fedora: > > ./scripts/build mode=release image=tests fs=rofs -j$(nproc) arch=aarch64 > --create-disk > > Building into build/release.aarch64 > > Makefile:1857: *** Error: libboost_system.a needs to be installed.. Stop. > > make failed. Exiting from build script
Yup - continuing with the theme from previous patch, the changes here are expecting the user to use the recently introduced "boost_base" to specify the location of the boost library. > On Mon, Feb 15, 2021 at 7:49 AM Punit Agrawal <[email protected]> wrote: > > Commits 5a9be20243fd ("boost: enhance main makefile to build against > arbitrary boost") and 765fa172ab41 ("boost: enhance modules/common.gmk > to build against arbitrary boost") added support for allowing the user > to specify arbitrary boost_base but left in place the special casing > when building for aarch64. > > As boost_base can also be used to specify the location for aarch64 > boost libraries when required, drop the extra logic that hard codes > paths for arm64 in favour of the more flexible approach. > > As an added benefit the change also enables cross building in > environments where the compiler can be trusted to correctly resolve > the library paths such as on Debian or Ubuntu. > > Signed-off-by: Punit Agrawal <[email protected]> > --- > Makefile | 33 ++++++++++----------------------- > modules/common.gmk | 27 +++++++-------------------- > 2 files changed, 17 insertions(+), 43 deletions(-) I get excited by negative diffstat. But let me know if it's too much to expect the user to specify boost_base - I'll rework the patches to revert to the hard coded paths. Thanks for taking the patches for a spin. Punit [...] -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/osv-dev/8735xueteq.fsf%40stealth.
