On Wed, May 3, 2023 at 7:40 PM Luca Abeni <lucab...@gmail.com> wrote:
> > On Sun, 16 Apr 2023 at 23:29, Luca Abeni <lucab...@gmail.com> wrote: > [...] > > > 2. There is no reason I can see for adding #define __NEED_size_t in > include/api/sched.hh > > > > I think this comes from Claudio's original patch; I'll remove it anyway > > I investigated this, and I now have some more information... > > include/api/sched.hh contains definitions like > int __sched_cpucount (size_t __setsize, const cpu_set_t *__setp) > that need time_t. > > Since the new "libc/rt/sched.cc" file includes api/sched.hh, the build > fails. I see that the only other file including api/sched.hh is > libc/pthread.cc, which includes osv/sched.hh before api/sched.hh... > And osv/sched.hh probably ends up defining __NEED_size_t; this is why > the #define was not needed before this patch. > Ok, I understand now. You're right. I forgot how we do these things. -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to osv-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/osv-dev/CANEVyjskxvetZGTucjZ4pdzOb0EnGO8opiynWzF59OfOdYdg%2Bw%40mail.gmail.com.
