The problem is here: https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Conntrack-tcp.c#L460
Looking back, it makes more sense to add them to OvsConntrackValidateIcmpPacket/OvsConntrackValidateTcpPacket. Should I revert the original patch and send one that chages the functions mentioned above? Thanks, Alin. > -----Original Message----- > From: Sairam Venugopal [mailto:vsai...@vmware.com] > Sent: Wednesday, November 30, 2016 8:15 PM > To: Yin Lin <yinli...@gmail.com>; Alin Serdean > <aserd...@cloudbasesolutions.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] datapath-windows: null comparison for icmp > and tcp header > > OvsConntrackValidateTcpPacket currently checks for NULL. I will update > OvsConntrackValidateIcmpPacket to check for NULL as well. > > > I acked this change to keep the checks consistent across different protocol. > > Thanks, > Sairam > > > On 11/29/16, 2:30 PM, "Yin Lin" <yinli...@gmail.com> wrote: > > >Can we decide if tcp and icmp is null in OvsConntrackValidateTcpPacket? > >It makes the function more complete and safer by itself. > > > >On Mon, Nov 28, 2016 at 6:11 AM, Alin Serdean < > >aserd...@cloudbasesolutions.com> wrote: > > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
