On Sun, Jan 08, 2017 at 04:34:54PM -0800, Mickey Spiegel wrote:
> On Fri, Jan 6, 2017 at 3:14 PM, Ben Pfaff <b...@ovn.org> wrote:
> > I suggest calling these "functions" instead of "conditions", but I
> > didn't make that change, except in the documentation.
>
> I was primarily distinguishing match criteria passed on to openflow,
> versus match criteria evaluated in expr_simplify(). A question for you:
>
> Suppose hypothetically that we solve my table 32 issue with
> something other than "chassisredirect" ports (though I still
> think that is the right way to go). In that case I would need to add
> another "condition" to only install certain flows on certain chassis.
>
> Should the syntax for that be:
> chassis == "chassis_name"
> or should it be:
> is_chassis("chassis_name")
> ?
> Should all criteria evaluated in expr_simplify() take on the syntax
> of functions?
>
> If the answer is yes / is_chassis, then I will change the name from
> "conditions" to "functions".
This is a great question. I hadn't thought of this case. I don't have
a solid answer.
Let's stick with "condition" for now then. It's just code, we can
change naming later.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
