On 10 January 2017 at 08:35, Paul Blakey <pa...@mellanox.com> wrote: > > > On 05/01/2017 23:43, Joe Stringer wrote: >> >> On 25 December 2016 at 03:39, Paul Blakey <pa...@mellanox.com> wrote: >>> >>> flow offloading by tc needs ingress qdisc on the device. >>> Deleting the ingress qdisc was done in order to flush >>> policing filters, so instead we just flush the filter and >>> leave the ingress added (and add it if there wasn't any). >>> >>> Signed-off-by: Paul Blakey <pa...@mellanox.com> >>> Reviewed-by: Roi Dayan <r...@mellanox.com> >> >> I'm concerned that this patch will break a bunch of things. >> >> I don't think we generally want an ingress qdisc unless there is >> specific policing configuration, or hardware offloads is enabled. This >> looks like it sets it up regardless. >> >> I suspect that if you changed policing configuration, it will not take >> effect with this patch. > > Right, policing will not work with offloads for now.
Further than that, if you configured one policing configuration, then changed to a different policing configuration (even without hardware offloads), I suspect it won't apply the new settings. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
