Hi, Thanks a lot for the series, it will be a great addition to the Windows datapath!
One small nit it does not compile under release because of `ovspool` is defined only in debug mode. I also tried to set up an environment and for some reason the fragments were stalling. I tried icmp and tcp with no luck. I will take a better look over the code and come back with more comments. Thanks, Alin. > -----Original Message----- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Tuesday, January 10, 2017 2:59 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v1 0/5] datapath-windows: Add support for Ipv4 > fragments > > Add support for maintaining and tracking IPv4 fragments. > This patch adds a new file IpFragment.c and IpFragment.h which includes > Ipv4 fragment related API's. > > Anand Kumar (5): > datapath-windows: Added a new file to support Ipv4 fragments. > datapath-windows: Added Ipv4 fragments support in Conntrack > datapath-windows: Retain MRU value in the OvsForwardingContext. > datapath-windows: Updated OvsTcpSegmentNBL to handle IP fragments. > datapath-windows: Fragment NBL based on MRU size > > datapath-windows/automake.mk | 2 + > datapath-windows/ovsext/Actions.c | 89 ++++-- > datapath-windows/ovsext/Actions.h | 3 + > datapath-windows/ovsext/BufferMgmt.c | 189 ++++++++---- > datapath-windows/ovsext/BufferMgmt.h | 10 +- > datapath-windows/ovsext/Conntrack.c | 31 +- > datapath-windows/ovsext/Conntrack.h | 7 +- > datapath-windows/ovsext/Debug.h | 3 +- > datapath-windows/ovsext/DpInternal.h | 2 +- > datapath-windows/ovsext/Geneve.c | 2 +- > datapath-windows/ovsext/Gre.c | 2 +- > datapath-windows/ovsext/IpFragment.c | 506 > +++++++++++++++++++++++++++++++++ > datapath-windows/ovsext/IpFragment.h | 74 +++++ > datapath-windows/ovsext/PacketIO.c | 5 +- > datapath-windows/ovsext/Recirc.c | 6 +- > datapath-windows/ovsext/Recirc.h | 6 +- > datapath-windows/ovsext/Stt.c | 2 +- > datapath-windows/ovsext/Switch.c | 9 + > datapath-windows/ovsext/Tunnel.c | 4 +- > datapath-windows/ovsext/User.c | 28 +- > datapath-windows/ovsext/User.h | 6 +- > datapath-windows/ovsext/Vxlan.c | 2 +- > datapath-windows/ovsext/ovsext.vcxproj | 2 + > 23 files changed, 885 insertions(+), 105 deletions(-) create mode 100644 > datapath-windows/ovsext/IpFragment.c > create mode 100644 datapath-windows/ovsext/IpFragment.h > > -- > 2.9.3.windows.1 > > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
