On 26 January 2017 at 23:14, Alin Serdean <aserd...@cloudbasesolutions.com> wrote:
> Found by inspection. > > Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> > --- > ovn/utilities/ovn-trace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c > index 307556b..2e2859a 100644 > --- a/ovn/utilities/ovn-trace.c > +++ b/ovn/utilities/ovn-trace.c > @@ -1224,7 +1224,7 @@ execute_output(const struct ovntrace_datapath *dp, > struct flow *uflow, > } > } > > - if (port->tunnel_key != in_key || allow_loopback) { > + if (port && (port->tunnel_key != in_key || allow_loopback)) { > The parentheses above feels odd. Did you want (port && port->tunnel_key != in_key) || allow_loopback) ? > struct ovntrace_node *node = ovntrace_node_append( > super, OVNTRACE_NODE_PIPELINE, > "egress(dp=\"%s\", inport=\"%s\", outport=\"%s\")", > -- > 2.10.2.windows.1 > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev