On Fri, Feb 10, 2017 at 7:03 PM, Alan Pevec <alan.pe...@redhat.com> wrote:
> In OVS 2.6 openvswitch systemd service was changed to use BindsTo
> instead of Requires for sub-services but also removed them from After
>
> This made main openvswitch service return before sub-services were ready
> breaking scripts which assumed everything is ready after systemctl start
> e.g. in OpenStack CI infra [1] is calling ovs-vsctl immediately after
> service start exposing a race in virtualized CI environment:
> 2017-02-09T23:11:12.498Z|00007|bridge|INFO|ovs-vswitchd (Open vSwitch)
> 2.6.1
> but ovs-ctl tried to access it few msec too early:
> 2017-02-09 23:11:12.352493 | ovs-vsctl: unix:/var/run/openvswitch/db.sock:
> database connection failed (No such file or directory)
>
> Solution is to add ordering dependencies, BindsTo/Requires do not ensure
> it [2]
>
> Fixes: 84ad120 ("rhel: Improved Systemd Integration")
>
> [1] https://github.com/openstack-infra/devstack-gate/blob/
> c435a724bd257b22a2e39e8e9125c11302a8c81d/functions.sh#L1057-L1078
>
> [2] https://www.freedesktop.org/software/systemd/man/systemd.
> unit.html#Requires=
>
> Signed-off-by: Alan Pevec <alan.pe...@redhat.com>
> Reviewed-by: Aaron Conole <acon...@redhat.com>
> ---
> rhel/usr_lib_systemd_system_openvswitch.service | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks for the patch! I added your name to the AUTHORS file and applied
this patch to master, branch-2.7, and branch-2.6.
--
Russell Bryant
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
