Regards _Sugesh
> -----Original Message----- > From: Roi Dayan [mailto:r...@mellanox.com] > Sent: Wednesday, February 15, 2017 7:30 AM > To: Chandran, Sugesh <sugesh.chand...@intel.com>; d...@openvswitch.org > Cc: r...@mellanox.com; Paul Blakey <pa...@mellanox.com>; Or Gerlitz > <ogerl...@mellanox.com>; Hadar Hen Zion <had...@mellanox.com>; Shahar > Klein <shah...@mellanox.com>; Mark Bloch <ma...@mellanox.com>; Rony > Efraim <ro...@mellanox.com>; Fastabend, John R > <john.r.fastab...@intel.com>; Joe Stringer <j...@ovn.org>; Andy > Gospodarek <a...@greyhouse.net>; Lance Richardson > <lrich...@redhat.com>; Marcelo Ricardo Leitner <mleit...@redhat.com>; > Simon Horman <simon.hor...@netronome.com>; Jiri Pirko > <j...@mellanox.com> > Subject: Re: [PATCH ovs V3 04/25] other-config: Add hw-offload switch to > control netdev flow offloading > > > > On 14/02/2017 01:53, Chandran, Sugesh wrote: > > > > > > Regards > > _Sugesh > > > > > >> -----Original Message----- > >> From: Roi Dayan [mailto:r...@mellanox.com] > >> Sent: Wednesday, February 8, 2017 3:29 PM > >> To: d...@openvswitch.org > >> Cc: Paul Blakey <pa...@mellanox.com>; Or Gerlitz > >> <ogerl...@mellanox.com>; Hadar Hen Zion <had...@mellanox.com>; > Shahar > >> Klein <shah...@mellanox.com>; Mark Bloch <ma...@mellanox.com>; > Rony > >> Efraim <ro...@mellanox.com>; Fastabend, John R > >> <john.r.fastab...@intel.com>; Joe Stringer <j...@ovn.org>; Andy > >> Gospodarek <a...@greyhouse.net>; Lance Richardson > >> <lrich...@redhat.com>; Marcelo Ricardo Leitner > <mleit...@redhat.com>; > >> Simon Horman <simon.hor...@netronome.com>; Jiri Pirko > >> <j...@mellanox.com>; Chandran, Sugesh <sugesh.chand...@intel.com> > >> Subject: [PATCH ovs V3 04/25] other-config: Add hw-offload switch to > >> control netdev flow offloading > >> > >> From: Paul Blakey <pa...@mellanox.com> > >> > >> } > >> > >> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index > >> 146a816..942e68f 100644 > >> --- a/vswitchd/vswitch.xml > >> +++ b/vswitchd/vswitch.xml > >> @@ -170,6 +170,17 @@ > >> <p> > >> The default is 10000. > >> </p> > >> + </column> > >> + > >> + <column name="other_config" key="hw-offload" > >> + type='{"type": "boolean"}'> > >> + <p> > >> + Set this value to <code>true</code> to enable netdev flow > >> offload. > >> + </p> > >> + <p> > >> + The default value is <code>false</code>. Changing this value > requires > >> + restarting the daemon > > [Sugesh] Hope its only the case of current implementation. Its possible to > change the hardware offload status at run-time in the future. The system will > re-populate the hardware ports accordingly when the status get changed. > > We actually already changed that and the current implementation is same as > for dpdk-init where we can change from false to true during run time but not > from true back to false again. can be fixed later. > > In case you do change this at run time we are missing to go over the netdevs > and add the needed ingress qdisc so this will be needed to be done manually > if working with this patchset. > We intend to fix this for V4. > > I see the comment requiring restart also still exists for dpdk-init. > Maybe we should keep it currently as well until it's fully supported.. [Sugesh] Ok, thank you for the information. > > >> + </p> > >> </column> > >> > >> <column name="other_config" key="dpdk-init" > >> -- > >> 2.7.4 > > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
