Hi Ben, Not a problem, Thank you for your reply. Will send out the next version of patch after the merge.
Regards _Sugesh > -----Original Message----- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Saturday, March 25, 2017 12:31 PM > To: Chandran, Sugesh <sugesh.chand...@intel.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v4 2/2] tunneling: Avoid recirculation on > datapath by computing the recirculate actions at translate time. > > Sorry I forgot to respond earlier, thanks for the reminder. I've now > responded directly to the previous message. > > On Sat, Mar 25, 2017 at 04:52:39AM +0000, Chandran, Sugesh wrote: > > Can anyone have a look and let me know the comments/suggestions? > > > > > > Regards > > _Sugesh > > > > > -----Original Message----- > > > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > > > boun...@openvswitch.org] On Behalf Of Chandran, Sugesh > > > Sent: Wednesday, March 8, 2017 1:52 PM > > > To: 'Ben Pfaff' <b...@ovn.org> > > > Cc: d...@openvswitch.org > > > Subject: Re: [ovs-dev] [PATCH v4 2/2] tunneling: Avoid recirculation > > > on datapath by computing the recirculate actions at translate time. > > > > > > Hi Ben, > > > Please find my answer below. > > > Regards > > > _Sugesh > > > > > > > > > > -----Original Message----- > > > > From: Ben Pfaff [mailto:b...@ovn.org] > > > > Sent: Tuesday, March 7, 2017 6:07 PM > > > > To: Chandran, Sugesh <sugesh.chand...@intel.com> > > > > Cc: d...@openvswitch.org; Gray, Mark D <mark.d.g...@intel.com>; > > > > jan.scheur...@ericsson.com; ja...@ovn.org; Zoltán Balogh > > > > <zoltan.bal...@ericsson.com> > > > > Subject: Re: [PATCH v4 2/2] tunneling: Avoid recirculation on > > > > datapath by computing the recirculate actions at translate time. > > > > > > > > On Thu, Feb 09, 2017 at 03:41:54PM +0000, Sugesh Chandran wrote: > > > > > Openvswitch datapath recirculates packets for tunneling, i.e. > > > > > the incoming packets are encapsulated at first pass. Further > > > > > actions are applied on encapsulated packets on the second pass > > > > > after > > > recirculating. > > > > > The proposed patch compute and append the post tunnel actions at > > > > > the time of translation itself instead of recirculating at datapath. > > > > > These actions are solely depends on tunnel attributes so there > > > > > is no need of > > > > datapath recirculation. > > > > > By avoiding the recirculation at datapath, the patch offers upto > > > > > 30% performance improvement for VxLAN tunneling in our testing. > > > > > The action execution logic is using the new CLONE action to > > > > > define the packet cloning when the actions are combined. The > > > > > lenght in the CLONE action specifies the size of nested action set. > > > > > > > > > > Also fixing the test suites failures that are introduced by > > > > > CLONE action in tunneling except the ovn test case 2299. > > > > > > > > I guess by this you mean that this test still consistently fails? > > > > 2301: ovn -- 1 LR with distributed router gateway port FAILED > > > > (ovn.at:6658) > > > > > > > > What's the plan for that, presumably we can't apply a patch that > > > > causes test failures? > > > [Sugesh] : The test case is failing due to the missing datapath rule. > > > With our limited knowledge on the OVN and OVS UT setup, Here are our > > > findings, The tunnel(in the test case its geneve) create two rules > > > in the datapath for packet forwarding. > > > The proposed patch is combining them into single rule to avoid the > > > recirculation and speed up the packet processing. > > > The failing test case is trying to send packets directly to the > > > outer bridge to match on nonexistent second rule. > > > Should we comment out this output validation in the test case? > > > Please let me know your inputs on this? Also looking for help from > > > OVN experts who can suggest a fix for the same? > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > dev mailing list > > > d...@openvswitch.org > > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
