Hi Anand, Thanks a lot for the patch.
At first glance the code looks ok. Just a small nit pick, can you please use a new memory pool tag instead of using `OVS_MEMORY_TAG`. Please define a new member after https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Util.h#L41 This will help us debugging either using a windows specific debugger to look at that specific pool or use tools (i.e. https://msdn.microsoft.com/en-us/windows/hardware/drivers/devtest/poolmon) Thanks, Alin. > -----Original Message----- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Friday, March 24, 2017 10:51 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v6 1/5] datapath-windows: Added a new file to > support Ipv4 fragments. > > This patch adds functionalities to support IPv4 fragments, which will be used > by Conntrack module. > > Added a new structure to hold the Ipv4 fragments and a hash table to hold > Ipv4 datagram entries. Also added a clean up thread that runs every minute > to delete the expired IPv4 datagram entries. > > The individual fragments are ignored by the conntrack. Once all the > fragments are recieved, a new NBL is created out of the reassembled > fragments and conntrack executes actions on the new NBL. > > Created new APIs OvsProcessIpv4Fragment() to process individual > fragments, > OvsIpv4Reassemble() to reassemble Ipv4 fragments. > > Signed-off-by: Anand Kumar <kumaran...@vmware.com> > --- > v5->v6: No Change > v4->v5: > - Modified Patch 3 to retain MRU in _OVS_BUFFER_CONTEXT instead of > using it in ovsForwardingContext with minor changes in rest of the > patches. > v3->v4: > - Rebase > - Acquire read lock for read operations. > v2->v3: > - using spinlock instead of RW lock. > - updated log messages, summary, fixed alignment issues. > v1->v2: > - Patch 4 updated to make it compile for release mode. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
