On Wed, Apr 12, 2017 at 9:12 AM, Stephen Finucane <step...@that.guru> wrote: > On Wed, 2017-04-12 at 08:58 -0400, Russell Bryant wrote: >> On Wed, Apr 12, 2017 at 7:29 AM, Stephen Finucane <step...@that.guru> >> wrote: >> > On Tue, 2017-04-11 at 13:15 -0400, Russell Bryant wrote: >> > > Update the version numbers in the documentation config to reflect >> > > 2.7.90 >> > > instead of 2.6.0. >> > > >> > > This patch also updates the build system to automatically update >> > > this >> > > file. >> > > conf.py is now a generated file from conf.py.in. We still >> > > include >> > > conf.py >> > > in the tree because it's needed for the docs to be automatically >> > > generated >> > > for docs.openvswitch.org. >> > > >> > > Signed-off-by: Russell Bryant <russ...@ovn.org> >> > >> > Looks OK, but how would we prevent this getting out of date? If >> > we're >> > going to include PATCH information, I imagine this would need to be >> > updated as part of every commit? >> >> It doesn't change with every commit. ".90" is fixed. "2.7.90" is >> the >> version OVS uses for the master branch that will eventually become >> 2.8. > > I realized that about 10 minutes ago after diving further into the git > history of NEWS :) Why '.90' , out of curiosity?
It predates my involvement, but I think it's roughly: 2.7.90 === much more than 2.7.0, but not quite 2.8.0 >> In terms of keeping it up to date, conf.py is going to show a change >> as soon as the version changes, but it should only be when a new >> branch gets created, or after a point release is made from a release >> branch. > > Gotcha. > >> > Seeing as a more generic version of this information is already >> > available in 'NEWS', I imagine we could just parse that instead. >> > Lemme >> > draft something quickly and see what you think. >> >> Cool, I'll take a look. > > Given the above, what I've done works but it likely unnecessary. Unless > we want to update the version in real time (by parsing git logs using > dulwich or similar), this solution is probably more consistent with > OVS' build system. As such: > > Acked-by: Stephen Finucane <step...@that.guru> > > Cheers :) > Stephen Thanks for the detailed review and feedback! I'll apply this approach, then. -- Russell Bryant _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
