Thanks a lot for fixing the leak Eric!

We should apply on 2.7 as well, but needs a rebase.

Is it okay if we add the function call on 2.7 as well or should we limit it too 
WIN32?

Acked-by: Alin Gabriel Serdean <[email protected]>

> -----Original Message-----
> From: [email protected] [mailto:ovs-dev-
> [email protected]] On Behalf Of Eric Garver
> Sent: Tuesday, April 11, 2017 4:15 PM
> To: ovs dev <[email protected]>
> Subject: Re: [ovs-dev] [PATCH] dpif-netlink: fix memory leak in
> dpif_netlink_port_del__() on WIN32
> 
> Do any of the windows folks have any feediback on the below patch?
> 
> Thanks.
> Eric.
> 
> On Tue, Apr 04, 2017 at 03:31:29PM -0700, Joe Stringer wrote:
> > On 4 April 2017 at 13:31, Eric Garver <[email protected]> wrote:
> > > Furthermore, the return code of dpif_netlink_port_query__() was not
> > > being checked.
> > >
> > > Signed-off-by: Eric Garver <[email protected]>
> > > ---
> >
> > For context, yes this adds the call to the Linux path as well but this
> > is already in the proposed rtnetlink patch series so I'm not concerned
> > about this.
> >
> > Here's my Ack. I'd like some windows folk to be aware and take a look
> > too though:
> > Acked-by: Joe Stringer <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to