> On Apr 17, 2017, at 4:47 PM, Ben Pfaff <b...@ovn.org> wrote:
>
> On Fri, Apr 14, 2017 at 05:25:48PM -0700, Jarno Rajahalme wrote:
>> Use the existing probed support flag for the original direction tuple
>> to determine if matches on the original direction tuple can be supported.
>>
>> Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
>> ---
>> ofproto/ofproto-dpif.c | 14 +++++++++++++-
>> 1 file changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
>> index c0212f2..25f8adf 100644
>> --- a/ofproto/ofproto-dpif.c
>> +++ b/ofproto/ofproto-dpif.c
>> @@ -4122,7 +4122,8 @@ check_mask(struct ofproto_dpif *ofproto, const struct
>> miniflow *flow)
>> support = &ofproto->backer->support.odp;
>> ct_state = MINIFLOW_GET_U8(flow, ct_state);
>> if (support->ct_state && support->ct_zone && support->ct_mark
>> - && support->ct_label && support->ct_state_nat) {
>> + && support->ct_label && support->ct_state_nat
>> + && support->ct_orig_tuple) {
>> return ct_state & CS_UNSUPPORTED_MASK ? OFPERR_OFPBMC_BAD_MASK : 0;
>> }
>
> I don't understand the above logic (before or after). Can you explain
> it? Maybe there needs to be a comment.
>
I guess a comment is needed, how about:
/* Do not bother dissecting the flow if the datapath supports all the features
we know of. */
Jarno
> Thanks,
>
> Ben.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
