On 13 April 2017 at 15:15, Jarno Rajahalme <ja...@ovn.org> wrote: > >> On Apr 13, 2017, at 2:08 PM, Joe Stringer <j...@ovn.org> wrote: >> >> On 15 March 2017 at 16:31, Jarno Rajahalme <ja...@ovn.org> wrote: >>> These are (mostly) datapath backports from master that fix existing >>> features in branch-2.7 and/or make the datapath compilable with later >>> Linux kernel code. >> >> Hi Jarno, >> >> This series was bigger than I expected, based on the general policy of >> backporting fixes (in the least invasive way possible) and not >> introducing new features or unrelated changes to existing branches. >> >> I have a counter-proposal patch series existing in this branch here, >> which strips 15 of the patches out: >> >> https://github.com/joestringer/openvswitch/commits/dev/jarno_ct_27_bp_v1 >> >> The nf_ct_delete() backport doesn't have a clear motivation described >> in the commit message so I don't know whether that's appropriate for >> backport. >> >> If you consider that master labels inheritance misfunctioning is a >> prominent bug for v2.7, here's the same branch with the labels >> refactor and inheritance fix for that on top (extra 4 patches); I >> didn't try to minimize the size of these changes, eg by dropping some >> of the refactoring patches: >> >> https://github.com/joestringer/openvswitch/tree/dev/jarno_ct_27_bp_v1%2Blabels >> > > I think it would be good to fix the inconsistent labels inheritance behavior > also for OVS 2.7. I looked over this branch, and it looks good except it also > needs this backport fix from master: > > commit 280337736851 (“datapath: Avoid struct copy on conntrack labels.")
Thanks for taking a look. I posted the counter-proposal more formally here: https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/331068.html With your ack I'd be happy to push it to branch-2.7. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev