On 19 April 2017 at 23:13, Roi Dayan <[email protected]> wrote: > > > On 14/04/2017 04:08, Joe Stringer wrote: >> >> On 7 April 2017 at 06:12, Roi Dayan <[email protected]> wrote: >>> >>> From: Paul Blakey <[email protected]> >>> >>> Using the new netdev flow api operate will now try and >>> offload flows to the relevant netdev of the input port. >>> Other operate methods flows will come in later patches. >>> >>> Signed-off-by: Paul Blakey <[email protected]> >>> Reviewed-by: Roi Dayan <[email protected]> >>> Reviewed-by: Simon Horman <[email protected]> >>> --- >> >> >> <snip> >> >>> static void >>> -dpif_netlink_operate(struct dpif *dpif_, struct dpif_op **ops, size_t >>> n_ops) >>> +dbg_print_flow(const struct nlattr *key, size_t key_len, >>> + const struct nlattr *mask, size_t mask_len, >>> + const struct nlattr *actions, size_t actions_len, >>> + const ovs_u128 *ufid, >>> + const char *op) >> >> >> I wonder if we could refactor log_flow_message() into somewhere >> neutral and share the output format for these flows from here and >> there. > > > we'll check it. can also use maybe the other logging functions as well > (put/del/get). > Need to modify to use the actual current module for logging instead of the > static this_module else everything will be logged as the dpif module.
True, good point. Feel free to do this as a follow-on patch for the series. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
