On Tue, Apr 04, 2017 at 03:50:41PM +0000, Zoltán Balogh wrote:
> From: Jan Scheurich <jan.scheur...@ericsson.com>
>
> Add support for actions push_eth and pop_eth to the netdev datapath and
> the supporting libraries. This patch relies on the support for these actions
> in the kernel datapath to be present.
>
> Signed-off-by: Lorand Jakab <loja...@cisco.com>
> Signed-off-by: Simon Horman <simon.hor...@netronome.com>
> Signed-off-by: Jiri Benc <jb...@redhat.com>
> Signed-off-by: Yi Yang <yi.y.y...@intel.com>
> Signed-off-by: Jean Tourrilhes <j...@labs.hpe.com>
> Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
> Co-authored-by: Zoltan Balogh <zoltan.bal...@ericsson.com>
This introduces new "sparse" warnings:
../lib/packets.c:267:27: warning: incorrect type in argument 1 (different
base types)
../lib/packets.c:267:27: expected unsigned short [unsigned] [usertype] x
../lib/packets.c:267:27: got restricted ovs_be16 [assigned] [usertype]
ethertype
../lib/packets.c:267:27: warning: restricted ovs_be16 degrades to integer
for this line of code:
packet->packet_type = PACKET_TYPE_BE(OFPHTN_ETHERTYPE, htons(ethertype));
and I agree with these warnings, because both arguments to
PACKET_TYPE_BE should be in host byte order.
I am very disappointed that, apparently, 7 people from 6 different
companies have contributed to this code without ever using a simple
build tool, recommended by the OVS documentation, that finds real bugs.
Please install sparse and use it. Then, after you fix the bugs that
sparse finds automatically for you, please resubmit the series.
Thanks,
Ben.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
