On Tue, Apr 25, 2017 at 05:02:14PM -0700, Andy Zhou wrote: > vswitchd can gracefully shutdown after receiving the 'appctl exit' > command. But the datapath resources vswitchd created can > linger on. This is not a problem, and in fact desireable when the > shutdown is transient in nature. Since restarted vswitchd usually > sees a similar configuration. By keeping the datapath resources > minimize the perturbation to the running data traffic. > > However, when vswitchd shutdown is permanent, there should be a > way to release the all datapath resources, so that they won't > be linger on forever. Add 'appctl quit' command for such purpose. > > Signed-off-by: Andy Zhou <az...@ovn.org>
Thanks for working on this. I have two categories of comments here. The first category is a general kind of unease over what problems this solves. I think it's better if we don't have to make the distinction between two ways to exit, and so I'd like to hear more specifically about the problems that this solves. The second category is just about naming. The two names "quit" and "exit" don't suggest different operations and so I think that they are likely to lead to confusion. I know that I, personally, will never remember which is which. I'd suggest, instead, making the existing "exit" take an option to explain what kind of shutdown is desired. Thanks, Ben. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
