On Wed, Apr 26, 2017 at 04:00:55PM +0100, Stephen Finucane wrote: > On Wed, 2017-04-26 at 10:55 -0400, Lance Richardson wrote: > > > From: "Ben Pfaff" <b...@ovn.org> > > > To: "Lance Richardson" <lrich...@redhat.com> > > > Cc: "Leif Madsen" <lmad...@redhat.com>, "ovs dev" <dev@openvswitch. > > > org> > > > Sent: Wednesday, 26 April, 2017 10:33:09 AM > > > Subject: Re: [ovs-dev] [RFC 2/4] doc: Convert ovs-vlan-test to rST > > > > > > On Tue, Apr 25, 2017 at 04:03:55PM -0400, Lance Richardson wrote: > > > > I ran into this a little while ago. The problem in my case was > > > > that > > > > sphinx-build > > > > was not installed, so these man pages were not being built (seems > > > > odd that > > > > this > > > > would not cause a build failure...) > > > > > > > > Doing "yum install python-sphinx" let me build the rpms > > > > successfully once > > > > again. Seems we should add "BuildRequires: python-sphinx" to the > > > > spec file. > > > > > > Huh. Somehow I thought that we'd made Sphinx an overall build > > > requirement. Maybe that's the right thing to do. > > > > > > > The rules to build rst-formatted man pages in the top-level > > Makefile.in are predicated on HAVE_SPHINX_TRUE, which does give the > > impression that Sphinx is optional. > > > > Lance > > Yup, it's optional since these were only used for HTML docs initially. > I didn't change that as HAVE_GROFF is also a thing, afaict, and I > wasn't sure if man pages were essential. Maybe they should be now.
HAVE_GROFF might be a deceptive example, because the availability of groff only affects whether the build can do a little bit of checking of the manpages' syntax at build time. It doesn't affect whether manpages can be built; they always can be. I'm inclined to try making Sphinx a hard requirement for the build, and then relaxing that if it proves untenable in practice. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
