> On Apr 27, 2017, at 10:31 AM, Joe Stringer <j...@ovn.org> wrote:
>
> On 24 April 2017 at 19:09, Jarno Rajahalme <ja...@ovn.org> wrote:
>> Linux 4.7 changed nf_connlabels_replace() to trigger conntrack event
>> for a label change only when the labels actually changed. Without
>> this change an update event is triggered even if the labels already
>> have the values they are being set to.
>>
>> There is no way we can detect this functional change from Linux
>> headers, so provide replacements that work the same for older Linux
>> releases regardless if a distribution provides backports or not.
>>
>> VMware-BZ: #1837218
>> Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
>> ---
>
> I assume that by "Linux 4.7", you're actually referring to the following
> commit?
> 5a8145f7b222 ("netfilter: labels: don't emit ct event if labels were
> not changed")
>
> It might be helpful for future reference (including review) to refer
> to this commit in the code comment below.
>
Right, thanks for suggesting this. I added this to both the commit message and
the code comment.
> Otherwise LGTM.
>
> Acked-by: Joe Stringer <j...@ovn.org>
Pushed to master,
Jarno
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
