> On Apr 27, 2017, at 4:15 PM, Joe Stringer <j...@ovn.org> wrote: > > On 27 April 2017 at 14:48, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: >> Specify the event mask with CT commit including bits for CT features >> exposed at the OVS interface (mark and label changes in addition to >> basic creation and destruction of conntrack entries). >> >> Without this any listener of conntrack update events will typically >> (depending on system configuration) receive events for each L4 (e.g., >> TCP) state machine change, which can multiply the number of events >> received per connection. >> >> By including the new, related, and destroy events any listener of new >> conntrack events gets notified of new related and non-related >> connections, and any listener of destroy events will get notified of >> deleted (typically timed out) conntrack entries. >> >> By including the flags for mark and labels, any listener of conntrack >> update events gets notified whenever the connmark or conntrack labels >> are changed from the values reported within the new events. >> >> VMware-BZ: #1837218 >> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> >> Acked-by: Joe Stringer <j...@ovn.org> >> --- > > Did you try building with sparse? I'm seeing: > > ofproto/ofproto-dpif.c:1256:19: error: incorrect type in initializer > (different base types) > ofproto/ofproto-dpif.c:1256:19: expected restricted ovs_be32 [usertype] nw_src > ofproto/ofproto-dpif.c:1256:19: got int > ofproto/ofproto-dpif.c:1257:19: error: incorrect type in initializer > (different base types) > ofproto/ofproto-dpif.c:1257:19: expected restricted ovs_be32 [usertype] nw_dst > ofproto/ofproto-dpif.c:1257:19: got int > ofproto/ofproto-dpif.c:1258:19: error: incorrect type in initializer > (different base types) > ofproto/ofproto-dpif.c:1258:19: expected restricted ovs_be16 [usertype] tp_src > ofproto/ofproto-dpif.c:1258:19: got int > ofproto/ofproto-dpif.c:1259:19: error: incorrect type in initializer > (different base types) > ofproto/ofproto-dpif.c:1259:19: expected restricted ovs_be16 [usertype] tp_dst > ofproto/ofproto-dpif.c:1259:19: got int
Thanks for reporting this! I’ve been unlucky getting sparse to not give me a ton of meaningless errors… Posted a v4 fixing this, Jarno _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
