On 27 April 2017 at 16:13, Greg Rose <gvrose8...@gmail.com> wrote: > Parenthetical imbalance was causing some checks to not run > > Signed-off-by: Greg Rose <gvrose8...@gmail.com> > --- > acinclude.m4 | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/acinclude.m4 b/acinclude.m4 > index 9f8e30d..0d6647e 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -681,9 +681,9 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ > > OVS_GREP_IFELSE([$KSRC/include/net/vxlan.h], [struct vxlan_metadata], > [OVS_DEFINE([HAVE_VXLAN_METADATA])]) > - OVS_GREP_IFELSE([$KSRC/include/net/udp.h], [udp_flow_src_port], > - [OVS_GREP_IFELSE([$KSRC/include/net/udp.h], > [inet_get_local_port_range(net], > - [OVS_DEFINE([HAVE_UDP_FLOW_SRC_PORT])])]) > + OVS_GREP_IFELSE([$KSRC/include/net/udp.h], [udp_flow_src_port]) > + OVS_GREP_IFELSE([$KSRC/include/net/udp.h], > [inet_get_local_port_range(net)], > + [OVS_DEFINE([HAVE_UDP_FLOW_SRC_PORT])])
I think this is deliberate.. Only if 'udp_flow_src_port' exists in net/udp.h, *AND* 'inet_get_local_port_range(net' exists, we define that HAVE_UDP_FLOW_SRC_PORT exists with the correct implementation. Otherwise, we'll provide an implementation of udp_flow_src_port. (Note that if 'udp_flow_src_port' exists but 'inet_get_local_port_range' taking 'net' does not, then HAVE_INET_GET_LOCAL_PORT_RANGE_USING_NET won't be defined, so we'll also backport that function for use from this backported function. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
