Ben Pfaff <b...@ovn.org> writes: > On Wed, Apr 26, 2017 at 11:54:52AM -0400, Aaron Conole wrote: >> The following series refactors checkpatch to make >> file-type specific checks. This lets checkpatch have >> finer grained checks, and should reduce the amount >> of false positives. >> >> Additionally, I've incorporated an older request to print >> files in the more standard `filename:lineno: ` form that >> most editors support out of the box. And while I was in >> there, I added pretty colors, because we all need some >> color in our terminals. >> >> v2: >> * Fix flake8 errors >> * Remove python from the line-length errors blacklist > > Thanks a lot for working on checkpatch. It's great to have more and > better tools for keeping quality high. > > But I still get flake8 errors. > > Added in patch 1, fixed in patch 5: > ../utilities/checkpatch.py:180:12: E999 SyntaxError: invalid syntax
D'oh! That's from some silly c-habits. Fixed. > Added in patch 3, never fixed: > ../utilities/checkpatch.py:202:14: E241 multiple spaces after ':' Oops. My flake8 setup had this warning turned off for some reason. Will be corrected in v3. Sorry. > Thanks, Thanks so much for the review, Ben! > Ben. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
