On Mon, May 01, 2017 at 04:01:12PM -0400, Aaron Conole wrote:
> Ben Pfaff <b...@ovn.org> writes:
>
> > On Mon, May 01, 2017 at 03:44:37PM -0400, Aaron Conole wrote:
> >> Developers wishing to add checks to checkpatch sift through an adhoc mess,
> >> currently. The process goes something like:
> >> 1. Figure out what to test in the patch
> >> 2. Write some code, quickly, that checks for that condition
> >> 3. Look through the statemachine to find where the check should go
> >> 4. ignore parts of the above and just throw something together
> >>
> >> That worked fine for the initial development, but as interesting new tests
> >> are developed, it is important to have a more flexible framework that lets
> >> a developer just plug in a new test, easily.
> >>
> >> This commit brings in a new framework that allows plugging in checks very
> >> quickly. Hook up the line-length test as an initial demonstration.
> >>
> >> Signed-off-by: Aaron Conole <acon...@redhat.com>
> >
> > With this, I get:
> >
> > ../utilities/checkpatch.py:180:12: E999 SyntaxError: invalid syntax
> >
> > where the cited line is:
> >
> > lambda(x): print_warning("Line is greater than 79-characters long", x)}
>
> d'oh! Trying it with python3, I see:
>
> File "./utilities/checkpatch.py", line 180
> lambda(x): print_warning("Line is greater than 79-characters long",
> x)}
> ^
> SyntaxError: invalid syntax
>
> So, I guess that is it. I'll submit a fix. I think I broke my python
> setup while doing some hacking on a different project, so I'll have to
> be more careful. Maybe now is the time to learn virtualenv.
>
> > I'm using:
> >
> > $ flake8 --version
> > 3.2.1 (mccabe: 0.5.3, pycodestyle: 2.2.0, pyflakes: 1.3.0) CPython
> > 3.5.1+ on Linux
>
> Yep, that's different from my version:
Diversity is strength, I guess.
> $ flake8 --version
> 2.5.5 (pep8: 1.6.2, mccabe: 0.2.1, pyflakes: 1.2.3, hacking.core: 0.0.1,
> ProxyChecker: 0.0.1) CPython 2.7.13 on Linux
Thanks, I'll look at v4.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
