On Mon, May 1, 2017 at 1:26 PM, Ben Pfaff <b...@ovn.org> wrote: > There's a bit of a problem with flake8 and release branches. The > release branches mainly stay the same, but flake8 marches on, and the > result is that building an old branch, e.g. branch-2.6, with modern > flake8 causes errors that break the build. > > I can think of several ways to deal with this:
In OpenStack, we pin to a specific version to avoid this type of problem. It's not so easy to use that solution here since we're just using whatever version of flake8 is installed on the system. > * Do something different on master and release branches, > e.g. change errors to warnings when we branch for release. > > * Only make flake8 warnings into errors when configured with > --enable-Werror. This one sounds good to me. > > * Only run flake8 when a configure option is given. > > * Apply fixes to release branches to avoid the warnings. > > Opinions? -- Russell Bryant _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
