On Tue, May 02, 2017 at 06:04:02PM -0700, Andy Zhou wrote: > On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff <b...@ovn.org> wrote: > > Until now, uuid_is_partial_string() returned the number of characters at > > the beginning of a string that were the beginning of a valid UUID. This > > is useful, but all of the callers actually wanted to get a value of 0 if > > the string contained a character that was invalid for a UUID. This makes > > that change. > > > > Examples: > > > > "123" previously yielded 3 and still does. > > "xyzzy" previously yielded 0 and still does. > > "123xyzzy" previously yielded 3, now yields 0. > > "e66250bb-9531-491b-b9c3-5385cabb0080" previously yielded 36, still does. > > "e66250bb-9531-491b-b9c3-5385cabb0080xyzzy" previously yielded 36, now 0. > > > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > Thanks for documenting those test cases in the commit message. It > seems we don't have > them in the actual unit tests. If you think it is worth while, I will > be happy a add those tests > and submit them in a separate patch. > > Acked-by: Andy Zhou <az...@ovn.org>
Thanks Andy and Russell, I applied this to master. Andy, tests are always helpful, if you have time for to add some then please do, and thanks for that. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
