On Tue, Apr 25, 2017 at 04:30:23PM +0000, Zoltán Balogh wrote:
> From: Jan Scheurich <jan.scheur...@ericsson.com>
> 
> Add support for actions push_eth and pop_eth to the netdev datapath and
> the supporting libraries. This patch relies on the support for these actions
> in the kernel datapath to be present.
> 
> Signed-off-by: Lorand Jakab <loja...@cisco.com>
> Signed-off-by: Simon Horman <simon.hor...@netronome.com>
> Signed-off-by: Jiri Benc <jb...@redhat.com>
> Signed-off-by: Yi Yang <yi.y.y...@intel.com>
> Signed-off-by: Jean Tourrilhes <j...@labs.hpe.com>
> Signed-off-by: Jan Scheurich <jan.scheur...@ericsson.com>
> Co-authored-by: Zoltan Balogh <zoltan.bal...@ericsson.com>

Hi, can you help me to understand this part here?  I believe that this
will lead to userspace sending a OVS_ACTION_ATTR_PUSH_ETH action
argument to the kernel that is different from what the kernel actually
wants.  What's the idea, and how is that problem avoided?

struct ovs_action_push_eth {
        struct ovs_key_ethernet addresses;
#ifndef __KERNEL__
    __be16  eth_type;
#endif
};

Thanks,

Ben.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to