On Thu, May 4, 2017 at 10:01 AM, Joe Stringer <j...@ovn.org> wrote: > On 3 May 2017 at 19:05, Pravin B Shelar <pshe...@ovn.org> wrote: >> From: Jiri Benc <jb...@redhat.com> >> >> Upstream commit: >> commit baf4d7860771287f30fbe9b6b2dc18b04361439d >> Author: Jiri Benc <jb...@redhat.com> >> Date: Thu Apr 27 21:24:36 2017 +0200 >> >> vxlan: do not output confusing error message >> >> The message "Cannot bind port X, err=Y" creates only confusion. In >> metadata >> based mode, failure of IPv6 socket creation is okay if IPv6 is disabled >> and >> no error message should be printed. But when IPv6 tunnel was requested, >> such >> failure is fatal. The vxlan_socket_create does not know when the error is >> harmless and when it's not. >> >> Instead of passing such information down to vxlan_socket_create, remove >> the >> message completely. It's not useful. We propagate the error code up to >> the >> user space and the port number comes from the user space. There's >> nothing in >> the message that the process creating vxlan interface does not know. >> >> Signed-off-by: Jiri Benc <jb...@redhat.com> >> Signed-off-by: David S. Miller <da...@davemloft.net> >> >> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> > > Acked-by: Joe Stringer <j...@ovn.org>
Thanks. I pushed patch to master, branch 2.6 and 2.7. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
