On 5/8/17, 5:24 PM, "William Tu" <u9012...@gmail.com> wrote:

    [snip]
    
    > -dnl Check ARP Snoop
    > +dnl Use arp reply to achieve tunnel next hop mac binding
    >  AT_CHECK([ovs-appctl netdev-dummy/receive br0 
'recirc_id(0),in_port(100),eth(src=f8:bc:12:44:34:b6,dst=ff:ff:ff:ff:ff:ff),eth_type(0x0806),arp(sip=1.1.2.92,ti
    >
    >  AT_CHECK([ovs-appctl tnl/neigh/show | tail -n+3 | sort], [0], [dnl
    > @@ -275,8 +261,6 @@ Listening ports:
    >  gre_sys (3)
    >  ])
    >
    > -AT_CHECK([ovs-ofctl add-flow br0 'priority=99,udp,action=normal'])
    > -
    we need this to make sure inner UDP packet isn't matched.

That is fine - leave this particular line then.
If it is meant as a kind of “smoke test” for the present breakage issue, then a 
comment is needed.

    
    >  dnl Check GRE tunnel push
    >  AT_CHECK([ovs-ofctl add-flow int-br action=3])
    >
    > @@ -287,8 +271,7 @@ AT_CHECK([tail -1 stdout], [0],
    >
    >  AT_CHECK([ovs-appctl netdev-dummy/receive int-br 
'50540000000a5054000000091234'])
    >  AT_CHECK([ovs-ofctl dump-flows br0 | ofctl_strip | sort], [0], [dnl)
    > - n_packets=3, n_bytes=140, priority=1 actions=NORMAL
    > - priority=99,udp actions=NORMAL
    > + n_packets=2, n_bytes=98, priority=1 actions=NORMAL
    >  NXST_FLOW reply:
    >  ])
    >
    Thanks for the feedback. I will submit v2 patch.
    William
    

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to