I found 4-5% throughput improvement when emc is disabled and it is a simple change Thanks for adding this.
Acked-by: Darrell Ball dlu...@gmail.com On 4/13/17, 11:30 AM, "ovs-dev-boun...@openvswitch.org on behalf of Bodireddy, Bhanuprakash" <ovs-dev-boun...@openvswitch.org on behalf of bhanuprakash.bodire...@intel.com> wrote: >On 04/13/2017 07:11 PM, Kevin Traynor wrote: >> On 03/12/2017 05:33 PM, Bhanuprakash Bodireddy wrote: >>> Conditional EMC insert patch gives the flexibility to configure the >>> probability of flow insertion in to EMC. This also allows an option >>> to entirely disable EMC by setting 'emc-insert-inv-prob=0' which can >>> be useful at large number of parallel flows. >>> >>> This patch skips EMC lookup when EMC is disabled. This is useful to >>> avoid wasting CPU cycles and also improve performance considerably. >>> >> >> LGTM. How much does this improve performance? I found significant performance improvement when testing with few hundred streams. I remember the improvement was ~800kpps with smaller packets. This is for the reason that emc_lookup() invokes expensive memcmp() to compare the netdev_flow_key in EMC and it takes up significant cycles. Longer the 'key', worse the performance. >Ack for the series, >Acked-by: Kevin Traynor <ktray...@redhat.com> Thanks kevin for the review and Acks. Regards, Bhanuprakash. _______________________________________________ dev mailing list d...@openvswitch.org https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=0nx_fadlj6m2KxOZGCsMJYGW9jUMnpXfb-sE5Aesw54&s=IeltQjLxliaHPElGHcd0mWdY7hRUJqbAEspM8CMkyco&e= _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev