> -----Original Message----- > From: Joe Stringer [mailto:j...@ovn.org] > Sent: Tuesday, May 23, 2017 2:39 AM > To: Alin Serdean <aserd...@cloudbasesolutions.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] tests: fix hanging test on windows > > On 22 May 2017 at 05:18, Alin Serdean <aserd...@cloudbasesolutions.com> > wrote: > > 'multiple bridges share a controller' hangs on windows because it is > > lacking the exit information (it will hang when the test has finished) > > > > Introduce a pidfile to 'ovs-testcontroller' and end it on exit based > > on the pidfile. > > > > Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> > > Hi Alin, > > "on_exit" will queue up a command to be run at the end of the test run, > regardless of success or failure. As such, I think that this should be run > immediately after the launch of ovs-testcontroller. > Otherwise it's possible that something else in the test fails before the end, > and ovs-testcontroller is not cleaned up. [Alin Serdean] Thanks for the review Joe! I was thinking about only the "happy path". I will send a new revision in which I will address the comments.
_______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev