On Thu, May 25, 2017 at 03:48:22PM -0700, Joe Stringer wrote:
> On 25 May 2017 at 13:54, Ben Pfaff <b...@ovn.org> wrote:
> > It's becoming more common that OSes include "ip" but not "ifconfig", so
> > it's best to avoid using the latter. This commit removes most references
> > to "ifconfig" and replaces them by "ip". It also adds a build-time check
> > to make it harder to introduce new uses of "ifconfig".
> >
> > Signed-off-by: Ben Pfaff <b...@ovn.org>
> > ---
>
> <snip>
>
> > diff --git a/tests/test-hash.c b/tests/test-hash.c
> > index d1beead36ed5..f02f0218c71f 100644
> > --- a/tests/test-hash.c
> > +++ b/tests/test-hash.c
> > @@ -153,14 +153,13 @@ check_hash_bytes128(void (*hash)(const void *,
> > size_t, uint32_t, ovs_u128 *),
> > OVS_PACKED(struct offset_ovs_u128 {
> > uint32_t a;
> > ovs_u128 b;
> > - }) in0_data;
> > - ovs_u128 *in0, in1;
> > + }) in0;
> > + ovs_u128 in1;
> > ovs_u128 out0, out1;
> >
> > - in0 = &in0_data.b;
> > - set_bit128(in0, i, n_bits);
> > set_bit128(&in1, i, n_bits);
> > - hash(in0, sizeof(ovs_u128), 0, &out0);
> > + in0.b = in1;
> > + hash(&in0.b, sizeof(ovs_u128), 0, &out0);
> > hash(&in1, sizeof(ovs_u128), 0, &out1);
> > if (!ovs_u128_equals(out0, out1)) {
> > printf("%s hash not the same for non-64 aligned data "
>
> This seems unrelated.
Oops. I sent a v2 (this is the only change).
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
