mf_set() always takes a nonnull mask, but the MFF_CT_LABEL case checked whether it was nonnull.
Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762941&defectInstanceId=4304057&mergedDefectId=179568 Signed-off-by: Ben Pfaff <b...@ovn.org> --- lib/meta-flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/meta-flow.c b/lib/meta-flow.c index 6b97794f1753..b82a27381991 100644 --- a/lib/meta-flow.c +++ b/lib/meta-flow.c @@ -2026,7 +2026,7 @@ mf_set(const struct mf_field *mf, case MFF_CT_LABEL: match_set_ct_label_masked(match, ntoh128(value->be128), - mask ? ntoh128(mask->be128) : OVS_U128_MAX); + ntoh128(mask->be128)); break; case MFF_ETH_DST: -- 2.10.2 _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
