On 26 May 2017 at 22:46, Ben Pfaff <b...@ovn.org> wrote:
> Coverity points out the following code in build_ipam() in ovn-northd.c:
>
> if (is_dynamic_lsp_address(nbsp->addresses[j])
> && !nbsp->dynamic_addresses) {
> if (!ipam_allocate_addresses(od, op,
> nbsp->addresses[j])
> || !extract_lsp_addresses(nbsp->dynamic_addresses,
> &op->lsp_addrs[op->n_lsp_addrs]))
> {
>
I think the intention is that ipam_allocate_addresses() would only return
success if nbsp->dynamic_addresses is allocated. So there should no null
deref.
>
> It's weird because it first verifies that nsbp->dynamic_addresses is
> null, and then immediately afterward passes it to
> extract_lsp_addresses(), which will dereference it. Presumably
> something else is really meant.
>
> Thoughts?
>
> Thanks,
>
> Ben.
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
