On Wed, Jun 07, 2017 at 02:12:08PM -0700, Ben Pfaff wrote: > On Wed, Jun 07, 2017 at 10:20:58AM +0100, Bhanuprakash Bodireddy wrote: > > Add netdev_txq_drain(), that drains packets on a queue. This is needed > > to transmit packets on the intermediate queue. > > > > Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> > > Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> > > Co-authored-by: Antonio Fischetti <antonio.fische...@intel.com> > > Signed-off-by: Markus Magnusson <markus.magnus...@ericsson.com> > > Co-authored-by: Markus Magnusson <markus.magnus...@ericsson.com> > > Thanks for working on Open vSwitch. This commit seems fine to me, but I > have a question about naming. Usually, pushing buffered data to a sink > is referred to as "flushing" the data, as in the fflush() function. > Perhaps it was named to match netdev_rxq_drain(), but that has a > different purpose: it discards data that has already been received.
It looks like this is the only patch that changes generic infrastructure as opposed to dpdk or dpif-netdev specific code, so I'll leave review of the rest to others. Thanks, Ben. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
