On 2 Dec 2025, at 15:05, Eelco Chaudron via dev wrote:
> Add flow control API calls to the dummy offload provider, enabling
> the re-addition of previously disabled partial offload tests.
>
> Signed-off-by: Eelco Chaudron <[email protected]>
One more problem that I will fix in v3 below.
[...]
> +static bool
> +dpif_offload_dummy_netdev_flow_stats(const struct dpif_offload *offload_,
> + struct netdev *netdev,
> + const ovs_u128 *ufid,
> + struct dpif_flow_stats *stats,
> + struct dpif_flow_attrs *attrs)
> +{
> + struct dummy_offloaded_flow *off_flow = NULL;
> + struct dpif_offload_dummy_port *port;
> +
> + port = dpif_offload_dummy_get_port_by_netdev(offload_, netdev);
> + if (!port) {
> + return false;
> }
>
> + ovs_mutex_lock(&port->port_mutex);
> + off_flow = dpif_offload_dummy_find_offloaded_flow(port, ufid);
> + ovs_mutex_unlock(&port->port_mutex);
> +
> + memset(stats, 0, sizeof *stats);
> + attrs->offloaded = off_flow ? true : false;
> + attrs->dp_layer = "tc";
This needs to be:
attrs->dp_layer = "ovs"; /* 'ovs', since this is a partial offload. */
> + attrs->dp_extra_info = NULL;
> +
> + return off_flow ? true : false;
> +}
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
