From: yaolingfei <[email protected]> The "member_may_enable__" function should be called after the "attached" variable is assigned a value of "true"; otherwise, "enable" will be permanently set to "false", which may result in failure to select the correct lead member.
96686dc6e0e7 (LACP: Check active partner sys id) Signed-off-by: yaolingfei <[email protected]> --- lib/lacp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/lacp.c b/lib/lacp.c index 3252f17eb..cacedff32 100644 --- a/lib/lacp.c +++ b/lib/lacp.c @@ -723,7 +723,6 @@ lacp_update_attached(struct lacp *lacp) OVS_REQUIRES(mutex) } member_get_priority(member, &pri); - bool enable = member_may_enable__(member); /* Check if partner MAC address is the same as on the working * interface. Activate member only if the MAC is the same, or @@ -733,6 +732,8 @@ lacp_update_attached(struct lacp *lacp) OVS_REQUIRES(mutex) lead_current->partner.sys_id))) { member->attached = true; } + + bool enable = member_may_enable__(member); if (member->attached && (!lead || enable > lead_enable -- 2.40.1.windows.1 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
