On 1/5/26 5:57 PM, Aaron Conole wrote: > Ilya Maximets <[email protected]> writes: > >> The FLOW_TNL_F_DONT_FRAGMENT and FLOW_TNL_F_CSUM are always present >> in the datapath flow mask, but OVS actually makes no decisions based >> on these bits, so there is no real need to match on them. They are >> also not exposed through OpenFlow, so users can't make decisions >> based on them either. And if it was possible, classifier would >> unwildcard them, e.g. like it is for the TNL_F_OAM bit. >> >> Having these bits always matched also doesn't play well with hardware >> offload as certain cards may not be able to match on these, even if >> TC supports this functionality. >> >> Clearing the bits and updating the tests accordingly. >> >> It's still important to match on the TNL_F_KEY as it is responsible >> for telling us if the tun_id field is populated or not. >> >> Signed-off-by: Ilya Maximets <[email protected]> >> --- > > Acked-by: Aaron Conole <[email protected]> >
Thanks! Applied and backported down to 3.5, as that's the version where we added the flag matching in tc, breaking the offload. Can technically go further, if needed in the future, but seems unnecessary for now. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
