On 7 Jan 2026, at 20:30, Aaron Conole wrote:
> Eelco Chaudron via dev <[email protected]> writes: > >> This patch introduces an API that allows offload providers to >> manage global configurations. It also moves the 'n-offload-threads' >> and 'tc-policy' setting to the appropriate providers using >> this new API. >> >> Signed-off-by: Eelco Chaudron <[email protected]> >> [...] >> +static void >> +dpif_offload_dpdk_set_config(struct dpif_offload *offload_, >> + const struct smap *other_cfg) >> +{ >> + struct dpif_offload_dpdk *offload = dpif_offload_dpdk_cast(offload_); >> + >> + /* We maintain the existing behavior where global configurations >> + * are only accepted when hardware offload is initially enabled. >> + * Once enabled, they cannot be updated or reconfigured. */ >> + if (smap_get_bool(other_cfg, "hw-offload", false)) { > > For this and the TC block, does it make sense to have a NEWS section and > also a warning that these global configs may be disappearing? Or > rather, I guess the idea is that there can be a global config and then a > per-dp offload state that shadows it? Otherwise, I don't understand the > comment block - maybe it would be better to have that as part of the > commit message. WDYT? You’re right, this comment does not make sense in the code. I’ll remove the comment (in both places) and update the commit message. FYI, the goal is not to change the behavior. Enablement remains global, but a port override is introduced in a later patch. >> + if (ovsthread_once_start(&offload->once_enable)) { >> + >> + offload_thread_nb = smap_get_ullong(other_cfg, >> + "n-offload-threads", >> + DEFAULT_OFFLOAD_THREAD_NB); >> + if (offload_thread_nb == 0 || >> + offload_thread_nb > MAX_OFFLOAD_THREAD_NB) { >> + VLOG_WARN("netdev: Invalid number of threads requested: %u", >> + offload_thread_nb); >> + offload_thread_nb = DEFAULT_OFFLOAD_THREAD_NB; >> + } >> + >> + if (smap_get(other_cfg, "n-offload-threads")) { >> + VLOG_INFO("Flow API using %u thread%s", >> + offload_thread_nb, >> + offload_thread_nb > 1 ? "s" : ""); >> + } >> + >> + ovsthread_once_done(&offload->once_enable); >> + } >> + } [...] _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
