On 9 Jan 2026, at 22:46, Aaron Conole wrote:
> Eelco Chaudron via dev <[email protected]> writes:
>
>> Relocate the tc flow dump functionality from netdev-offload
>> to dpif-offload, centralizing flow dump handling in the
>> dpif-offload layer.
>>
>> Signed-off-by: Eelco Chaudron <[email protected]>
>> ---
>>
>> v2 changes:
>> - Use ovs_mutex_destroy() instead of ovs_mutex_init() in
>> dpif_offload_tc_flow_dump_destroy().
>> ---
>> lib/dpif-offload-provider.h | 3 +
>> lib/dpif-offload-tc.c | 248 ++++++++++++++++++++++++++++++++++--
>> lib/dpif-offload.c | 6 +
>> lib/netdev-offload-tc.c | 34 +++--
>> lib/netdev-offload-tc.h | 9 ++
>> 5 files changed, 267 insertions(+), 33 deletions(-)
>>
>> diff --git a/lib/dpif-offload-provider.h b/lib/dpif-offload-provider.h
>> index 2c761c13e..8840441c0 100644
>> --- a/lib/dpif-offload-provider.h
>> +++ b/lib/dpif-offload-provider.h
>> @@ -281,6 +281,7 @@ bool dpif_offload_port_mgr_add(struct
>> dpif_offload_port_mgr *,
>> struct dpif_offload_port_mgr_port *dpif_offload_port_mgr_remove(
>> struct dpif_offload_port_mgr *, odp_port_t, bool keep_netdev_ref);
>> void dpif_offload_port_mgr_uninit(struct dpif_offload_port_mgr *);
>> +size_t dpif_offload_port_mgr_port_count(struct dpif_offload_port_mgr *);
>> struct dpif_offload_port_mgr_port *dpif_offload_port_mgr_find_by_ifindex(
>> struct dpif_offload_port_mgr *, int ifindex);
>> struct dpif_offload_port_mgr_port *dpif_offload_port_mgr_find_by_netdev(
>> @@ -292,6 +293,8 @@ void dpif_offload_port_mgr_traverse_ports(
>> bool (*cb)(struct dpif_offload_port_mgr_port *, void *),
>> void *aux);
>>
>> +#define DPIF_OFFLOAD_PORT_MGR_PORT_FOR_EACH(PORT, PORT_MGR) \
>> + CMAP_FOR_EACH (PORT, odp_port_node, &(PORT_MGR)->odp_port_to_port)
>
> Since you're spinning another version, I think this might be better
> added in
>
> [07/40] dpif-offload: Add port registration and management APIs.
>
> At least because it can be used as the FOR construct in
> `dpif_offload_port_mgr_traverse_ports`
Good catch, moved this to patch 7.
[...]
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
