Re: [ovs-dev] [PATCH v5 15/40] dpif-offload: Move the flow_get_n_flows() netdev-offload API to dpif.

[Eelco Chaudron via dev]

On 13 Jan 2026, at 21:51, Ilya Maximets wrote:

> On 1/12/26 12:20 PM, Eelco Chaudron wrote:
>> This patch moved the flow count APIs to the netdev-offload provider.
>>
>> Acked-by: Eli Britstein <elibr.nvidia.com>
>> Signed-off-by: Eelco Chaudron <echau...@redhat.com>

[...]
>> diff --git a/lib/dpif-offload-provider.h b/lib/dpif-offload-provider.h
>> index f49443758..5e403894e 100644
>> --- a/lib/dpif-offload-provider.h
>> +++ b/lib/dpif-offload-provider.h
>> @@ -132,6 +132,9 @@ struct dpif_offload_class {
>>       * successful, otherwise returns a positive errno value. */
>>      int (*flow_flush)(const struct dpif_offload *);
>>
>> +    /* Returns the number of flows offloaded by the offload provider. */
>> +    uint64_t (*flow_get_n_offloaded)(const struct dpif_offload *);
>
> The name is a little strange for a class member.  Should we maybe call
> it just .get_n_flows() or .flow_count() ?  Since we're asking the
> offload provider and not the general dpif implementation it's expected
> that all the flows in there are offloaded.
>
>> +
>>      /* Adds or modifies the meter in 'dpif_offload' with the given 
>> 'meter_id'
>>       * and the configuration in 'config'.
>>       *

Sound like a good idea, renamed to flow_count to keep the flow prefix.

//Eelco

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev