On 1/9/26 8:15 PM, Frode Nordahl wrote:
> The tc command from iproute2 changed its rounding behavior in commit
> d947f365602b ("tc: Fix rounding in tc_calc_xmittime and tc_calc_xmitsize.").
> This caused the "QoS - basic configuration", "QoS - 64bit" and
> "Ingress Policing - 64-bit" tests to fail because they were matching exact
> burst and cburst values in tc output.
>
> For consistency and as a proactive measure in case of further changes to
> tc, the following tests are also updated, although they are currently not
> directly affected:
> "offloads - set ingress_policing_rate and ingress_policing_burst - offloads
> disabled"
> "offloads - set ingress_policing_rate and ingress_policing_burst - offloads
> enabled"
>
> The rounding fix means that burst and cburst values may differ slightly
> from previous versions. For example, values that were previously 750000
> might now be 749999 or similar variations.
>
> To maintain compatibility with both old and new versions of tc, the test
> assertions now use pattern matching with dots that:
> - Matches the most significant digit of the value
> - Uses dots to match any character for remaining digits
> - Maintains the correct total number of digits
> - Preserves the unit suffix (e.g., 'b' for bytes)
>
> For example, '375000b' now matches '3.....b' which accepts any 6-digit
> value starting with 3, allowing for rounding differences while still
> validating the general magnitude is correct.
>
> This follows the same approach as the related OVN patch:
> https://mail.openvswitch.org/pipermail/ovs-dev/2025-December/428593.html
>
> Reported-at: https://launchpad.net/bugs/2129005
> Assisted-by: claude-sonnet-4.5, GitHub Copilot CLI
> Signed-off-by: Frode Nordahl <[email protected]>
> ---
> tests/system-offloads-traffic.at | 14 ++++++--------
> tests/system-traffic.at | 12 ++++++------
> 2 files changed, 12 insertions(+), 14 deletions(-)
Thanks! Applied and backported down to 3.3.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
