On 15 Jan 2026, at 23:45, Dima Chumak wrote:
> On 2026-01-15 10:45 AM, Eelco Chaudron wrote:
>> External email: Use caution opening links or attachments
>> On 15 Jan 2026, at 0:42, Ilya Maximets wrote:
>>> On 1/9/26 9:03 PM, Dima Chumak via dev wrote:
[...]
>>> Hi. To save some iteration time as we're about to branch for 3.7 release,
>>> I fixed a few minor style issues throughout the set and made the following
>>> small change to the 'rule/show' command:
>>>
>>> diff --git a/lib/ovs-router.c b/lib/ovs-router.c
>>> --- a/lib/ovs-router.c
>>> +++ b/lib/ovs-router.c
>>> @@ -907,17 +908,9 @@ ovs_router_rules_show_text(struct ds *ds, bool ipv6)
>>> continue;
>>> }
>>> if (rule->user) {
>>> - if (rule->ipv4) {
>>> - ds_put_format(ds, "User: ");
>>> - } else {
>>> - ds_put_format(ds, "User6: ");
>>> - }
>>> + ds_put_format(ds, "User: ");
>>> } else {
>>> - if (rule->ipv4) {
>>> - ds_put_format(ds, "Cached: ");
>>> - } else {
>>> - ds_put_format(ds, "Cached6: ");
>>> - }
>>> + ds_put_format(ds, "Cached: ");
>>> }
>>> ds_put_format(ds, "%"PRIu32": ", rule->prio);
>>> if (rule->invert) {
>>> ---
>>>
>>> (There is no need to print the extra '6', as we're only printing rules for
>>> one family that was explicitly requested.)
>>>
>>> With that, applied the series to main.
>>>
>>> It's a nice feature to have. Thanks!
>>>
>>> Best regards, Ilya Maximets.
>>
>> Looks like this series introduced some Coverity issues :(
>> Dima, can you take a look and send a patch?
>
> Sure, I've sent the fixes. I don't have access to Coverity to verify
> them though.
Thanks for the patches; they solved the problem.
//Eelco
[...]
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
