Bleep bloop. Greetings Naveen Yerramneni, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should end with a dot.
Subject: northd, tests: Network Function vtap mode logical flow changes
WARNING: Line is 81 characters long (recommended limit is 79)
#41 FILE: NEWS:84:
network functions can observe traffic without being inline in the data
path.
WARNING: Line is 80 characters long (recommended limit is 79)
#147 FILE: northd/northd.c:3226:
enum nf_port_binding_state port_state = network_function_port_binding_state(
WARNING: Line is 80 characters long (recommended limit is 79)
#183 FILE: northd/northd.c:6162:
const char *egress_action = (has_stateful_acl && !lsp_is_localnet(op->nbsp))
WARNING: Line is 83 characters long (recommended limit is 79)
#212 FILE: northd/northd.c:18321:
network_function_group_get_fallback(const struct nbrec_network_function_group
*nfg)
WARNING: Line is 80 characters long (recommended limit is 79)
#435 FILE: northd/northd.c:18762:
* of the ingress pipeline. Original packet continues with ingress pipeline.
WARNING: ovn-sbctl return should be checked Consider adding check or check_uuid
in front.
#584 FILE: tests/ovn-northd.at:18453:
ovn-sbctl chassis-add gw1 geneve 127.0.0.1 + -- set chassis gw1
other_config:ovn-ct-lb-related=true + -- set chassis gw1
other_config:ct-no-masked-label=true
WARNING: ovn-sbctl return should be checked Consider adding check or check_uuid
in front.
#609 FILE: tests/ovn-northd.at:18717:
ovn-sbctl chassis-add gw1 geneve 127.0.0.1 + -- set chassis gw1
other_config:ovn-ct-lb-related=true + -- set chassis gw1
other_config:ct-no-masked-label=true
WARNING: ovn-sbctl return should be checked Consider adding check or check_uuid
in front.
#647 FILE: tests/ovn-northd.at:18754:
ovn-sbctl chassis-add gw1 geneve 127.0.0.1 + -- set chassis gw1
other_config:ovn-ct-lb-related=true + -- set chassis gw1
other_config:ct-no-masked-label=true
Lines checked: 1463, Warnings: 9, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
