Hi Aditya. I just attempted to merge this and ran into a problem with patch 2:

Applying: northd, controller, lib: Add Pre-NF stage and store NF ID in ct_label.
error: sha1 information is lacking or useless (tests/ovn.at).
error: could not build fake ancestor

Can you please rebase your patches and post a v4? If you do that, I
will merge the rebased series. Thanks!

On Tue, Feb 10, 2026 at 5:14 PM Mark Michelson <[email protected]> wrote:
>
> Thanks for the v3 Aditya. For the whole series:
>
> Acked-by: Mark Michelson <[email protected]>
>
> On Mon, Feb 9, 2026 at 3:25 AM Aditya Mehakare
> <[email protected]> wrote:
> >
> > This patch series contains the changes to commit the Network Function ID
> > instead of Network Function Group ID in connection tracking label.
> >
> > This introduces the PRE_NF pipeline stage and modifies the
> > connection tracking label storage to use individual network function IDs
> > instead of group IDs. The PRE_NF stage (table 23 for ingress, table 11
> > for egress) selects the active network function from a group based on
> > health monitoring status and configured fallback behavior. It sets the
> > specific NF ID in reg0[22..29], which is then stored in ct_label.nf_id by
> > the STATEFUL stage. This allows response and related packets to be
> > redirected to the same network function instance that handled the request
> > packet, enabling proper stateful processing and NF active-active
> > support.
> >
> > V1:
> >  - Add id column to Network Function NB schema.
> >
> > V2:
> >  - Address review comments by Dumitru to commit NF id instead of NFG id in 
> > CT.
> >
> > V3:
> >  - Address review comments by Mark to update a comment in northd.
> >
> > Aditya Mehakare (2):
> >   ovn-nb, ovn-nbctl: Add ID column to Network_Function table.
> >   northd, controller, lib: Add Pre-NF stage and store NF ID in ct_label.
> >
> >  controller/lflow.h           |  14 +-
> >  include/ovn/logical-fields.h |   8 +-
> >  lib/logical-fields.c         |  10 +-
> >  lib/ovn-util.c               |   4 +-
> >  lib/ovn-util.h               |   4 +-
> >  northd/northd.c              | 118 +++++---
> >  northd/northd.h              |  34 ++-
> >  northd/ovn-northd.8.xml      | 305 +++++++++++++++-----
> >  ovn-nb.ovsschema             |  10 +-
> >  ovn-nb.xml                   |   5 +
> >  ovn-sb.ovsschema             |   6 +-
> >  tests/ovn-macros.at          |  12 +-
> >  tests/ovn-nbctl.at           |  48 +++-
> >  tests/ovn-northd.at          | 523 ++++++++++++++++++++---------------
> >  tests/ovn.at                 |  14 +-
> >  tests/system-ovn.at          |   4 +-
> >  utilities/ovn-nbctl.8.xml    |  19 +-
> >  utilities/ovn-nbctl.c        |  25 +-
> >  18 files changed, 751 insertions(+), 412 deletions(-)
> >
> > --
> > 2.43.5
> >
> > _______________________________________________
> > dev mailing list
> > [email protected]
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to