On 9 Feb 2026, at 12:17, David Marchand via dev wrote:

> Currently, if one incorrect mac is set, a first log with little context
> is displayed, followed by a more complete one.
>
> Besides, if no port can be identified with the passed mac, then no
> explanation is displayed.
>
> Report some details in a single log.
>
> Before:
> netdev_dpdk|ERR|invalid mac: 00:00:00:00:00:
> netdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:'
>       to DPDK
> ...
> netdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:00'
>       to DPDK
>
> After:
> netdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:'
>       to DPDK: invalid mac
> ...
> netdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:00'
>       to DPDK: unknown mac
>
> Signed-off-by: David Marchand <[email protected]>

Hi David,

Thanks for cleaning this up!

One comment on the error message: since this is already reported by 
netdev-dpdk, maybe we can remove the “to DPDK” part?

So it would become:

  netdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:00': 
invalid mac

WDYT?

//Eelco


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to