On 12.02.2026 14:43, Dumitru Ceara wrote: Внимание: ВНЕШНИЙ отправитель!
Будьте осторожны с вложениями и ссылками. On 2/11/26 4:15 PM, Dumitru Ceara wrote: On 2/7/26 10:48 PM, Alexandra Rukomoinikova wrote: Add schema and CLI support for health checks on logical switch ports by introducing a new health check table and linking it from logical switch ports. Implement corresponding ovn-nbctl commands to manage LSP health checks. Also extend service monitoring to support the logical-switch-port type. Signed-off-by: Alexandra Rukomoinikova <[email protected]><mailto:[email protected]> --- v1 --> v2: corrected all the comments and made one service monitor bind to only one address --- Hi Alexandra, At a first glance this seems OK to me, only a few minor comments below. I'll review the rest of the patches in the series and come back to this one with an Ack if applicable. Hi Alexandra, I finished reviewing the series and there are some things that should be fixed at least in the first 5 patches. Whether we accept the last 3 refactor patches or not in 26.03 is still a bit of an open discussion. I'm currently inclining towards a v4 that: - addresses the issues found during review - squashes patch 6/8 into patch 3 - includes patches 7/8 and 8/8 (maybe in a different order as patch 7/8 might need more discussion and is less likely to be accepted as is in 26.03). Patch 7 could also be split further, separating the generic set_field helpers into their own patch. What do you think? Thanks, Dumitru Hi Dumitu! Thanks for the review) Yes, I will resend next version taking into account everything you said. I'll try to do it quickly this week. And once again, sorry for the problem that was in patch 4, related to the fact that I didn't address the comment from previous version. -- regards, Alexandra. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
