On 2/17/26 2:49 PM, Dumitru Ceara wrote: > On 2/16/26 7:02 PM, Ales Musil via dev wrote: >> On Mon, Feb 16, 2026 at 10:20 AM Ales Musil <[email protected]> wrote: >> >>> Remove the condition that would prevent ovn-kubernetes jobs >>> to run weekly. >>> >>> Signed-off-by: Ales Musil <[email protected]> >>> --- > > Hi Ales, > > This makes sense to me. > >>> .github/workflows/ovn-kubernetes.yml | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/.github/workflows/ovn-kubernetes.yml >>> b/.github/workflows/ovn-kubernetes.yml >>> index 857d12ada..e938293d2 100644 >>> --- a/.github/workflows/ovn-kubernetes.yml >>> +++ b/.github/workflows/ovn-kubernetes.yml >>> @@ -69,7 +69,6 @@ jobs: >>> >>> e2e: >>> name: e2e >>> - if: github.event_name != 'schedule' > > We also have: > > name: Build > if: github.repository_owner == 'ovn-org' || github.event_name != > 'schedule' > > Which means, I think, that scheduled jobs will perma-fail > in forks of ovn-org/ovn because the build stage is skipped, > right? >
Hmm, I'm wrong, the e2e step will be skipped because it depends on the build step which won't run in forks of ovn-org/ovn on a schedule: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idneeds > Should we remove that part of the condition too? > > I didn't test it but it should work fine so, if you agree > with that change: > > Acked-by: Dumitru Ceara <[email protected]> So I went ahead and applied your original patch to main. Thanks, Dumitru > >>> runs-on: ubuntu-24.04 >>> timeout-minutes: 220 >>> strategy: >>> -- >>> 2.53.0 >>> >>> >> The ovn-k CI should be fixed now. >> >> Recheck-request: github-robot-_ovn-kubernetes > > Thanks, > Dumitru > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
